Skip to content

fix(task-board): stop hardcoding 'in_progress' in the failed-run reaction #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrofrxncx merged 1 commit into from
Sep 2, 2026
Merged

fix(task-board): stop hardcoding 'in_progress' in the failed-run reaction #6854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/api/src/tools/task-board/run-reactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,4 +322,11 @@ describe("reactToFailedTaskRun on a card that already moved on", () => {
await reactToFailedTaskRun(taskBoard, "thr-1", "org-1", CANON_LANES);
expect(calls).toEqual(["retry"]);
});

it("retries a card mid-work on an org-owned board whose progress column isn't named 'in_progress'", async () => {
const orgLanes = { ...CANON_LANES, progress: "col-doing" };
const { taskBoard, calls } = fakeBoard("col-doing");
await reactToFailedTaskRun(taskBoard, "thr-1", "org-1", orgLanes);
expect(calls).toEqual(["retry"]);
});
});
2 changes: 1 addition & 1 deletion apps/api/src/tools/task-board/run-reactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ export async function reactToFailedTaskRun(
.relabelDeliveredFailure(threadId, orgId, DELIVERED_FAILURE_REASON)
.catch(() => {});
}
if (item.status !== "in_progress") continue;
if (item.status !== lanes.progress) continue;
// A REVIEWER's run failed, not the author's: the card is In Progress only
// because that is where a card under review sits now. Retrying it here
// would dispatch a fresh Super Agent run over a PR that is waiting for a
Expand Down
Loading