fix: isolate Familiar Mix execution - #25
Open
Oscar-Williams wants to merge 1 commit into
Open
Oscar-Williams wants to merge 1 commit into
Oscar-Williams wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A rooted Familiar currently allowlists
compileandformatby default, so workspace Mix code can run before an operator opts in. Mix children also inherit the BEAM process environment, which can expose credentials to untrusted workspace code.Fix
run_tests: trueexplicitly opts intotest.Validation
mix test test/mix_gate_test.exs(9 passed)mix test test/familiar_test.exs:52 test/familiar_test.exs:64 test/familiar_test.exs:119(3 passed)mix compile --warnings-as-errorsmix format --check-formattedandmix credo --ignore refactoron a clean LF checkoutCloses #24