Repository navigation
Resize Composer when its available width changes - #31
Merged
Merged
Conversation
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Composer only measured its textarea after text changed. Narrowing its parent could wrap an existing one-line draft into three lines while leaving the textarea 32px tall; typing another character was required to reveal the draft at its intended height.
What changes
Observe the textarea's available width and run its existing sizing logic when that width changes, including changes caused by panels or attachments. Ignore height-only observer notifications to avoid resize feedback and disconnect the observer on unmount. Existing text-change sizing and the maximum height remain unchanged.
How it was checked
npm ci,npm run docs,npm run typecheck, andnpm run buildpass on Node 26.3.0./dev/examplesreports 389/389 mounted and 0 failed in each theme, without page errors.Before review
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failedsrc/examples/and its page incontent/solid/