Repository navigation
Preserve changed lines that resemble unified diff headers - #34
Merged
Merged
Conversation
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DiffView and patchStats discarded every line beginning with
+++or---, including genuine hunk content. For example, changing--count;to++count;produces such prefixes in a real Git patch, so changes disappeared and their statistics were undercounted.What changes
Share a small line-filtering helper between rendering and statistics. Track hunk line counts to distinguish changed content from file headers, reset at Git file boundaries, and keep support for compact tool-output hunks. Document the input boundary: complete unified hunks can distinguish file headers by their counts; multi-file compact or truncated output needs
diff --gitseparators. Keeping changed text takes precedence when shortened output omits that information. The public API and styling are unchanged.How it was checked
npm ci,npm run docs,npm run typecheck, andnpm run buildpass on Node 26.3.0./dev/examplesreports 389/389 mounted and 0 failed in both themes, without page errors.git diff --no-indexand compared counts with Git's--numstat: prefix-like code/Markdown lines,--- literal/+++ literalhunk text, empty added/deleted lines, missing final newlines, and multiple files all retain their changed lines and correct counts.diff --gitboundaries.Before review
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failedsrc/examples/and its page incontent/solid/