Repository navigation
Keep TurnStatus disclosures accessible and activity announcements quiet - #54
Merged
WaylandYang merged 2 commits intoOct 18, 2026
Merged
Conversation
Signed-off-by: Maya Kid <29959320+Maya-Kid@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With children, TurnStatus renders a
buttonwithrole="status", hiding its disclosure from assistive technology's button navigation. The live region also includes the ticking timer and animated token count.Keep the native button role and give it a stable activity name. Announce activity changes through a separate screen-reader-only status region; omitted or blank labels fall back to the activity name. The visible counters and Enter/Space disclosure behavior stay the same.
This is the standalone accessibility follow-up separated from #30 after review.
Validation:
npm run docs,npm run typecheck, andnpm run buildpass.Chrome 155, light and dark: 389/389 examples mounted, 0 failed, no browser errors.
Accessibility-tree checks cover the native button role, stable names, omitted/blank/localized labels, activity changes, and the status without children. Enter and Space expand/collapse the details.
Changing tokens from 42 to 4,242 and advancing the timer produces no mutations in the activity status region. Checked the closed and expanded views in both themes.
Every commit is signed off (
git commit -s)npm run typecheckandnpm run buildpass/dev/examplesreports0 failedWhat the change touches was looked at in both themes, open states included
The component has its example in
src/examples/and its page incontent/solid/