Repository navigation
Move the hardcoded feed endpoint placeholder to the i18n bundle - #1229
Merged
WaylandYang merged 1 commit intoOct 14, 2026
Merged
Conversation
Signed-off-by: Zhoulu <ldazzh@lineadirecta.es>
WaylandYang
approved these changes
Oct 14, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
Thank you, and welcome. A small, clean change: the last literal string in that modal now comes from the bundle like its neighbours. CI is green.
Merging. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The custom source endpoint placeholder was hardcoded as
"https://your-service/utopia-feed"— the only hardcoded English string in the source modal. All sibling fields (endpointField,endpointCopied,copyEndpoint) already useS.library.*keys.What changes
web/src/i18n/en.ts— addsfeedPlaceholder: "https://your-service/utopia-feed"web/src/i18n/zh.ts— addsfeedPlaceholder: "https://your-service/utopia-feed"(same value, it is a URL)web/src/pages/Library.tsx— replaces the hardcoded string withS.library.feedPlaceholderHow it was checked
pnpm buildandpnpm testpass locally and in CIBefore review
git commit -s)web/:pnpm buildandpnpm testpassweb/src/i18n/en.tsandzh.ts