Skip to content

Move the hardcoded feed endpoint placeholder to the i18n bundle - #1229

Merged
WaylandYang merged 1 commit into
deeplethe:devfrom
Schro-code:fix/library-feed-placeholder
Oct 14, 2026
Merged

WaylandYang merged 1 commit into
deeplethe:devfrom
Schro-code:fix/library-feed-placeholder

Conversation

@Schro-code

@Schro-code Schro-code commented Oct 14, 2026 •

Copy link
Copy Markdown

Why

The custom source endpoint placeholder was hardcoded as "https://your-service/utopia-feed" — the only hardcoded English string in the source modal. All sibling fields (endpointField, endpointCopied, copyEndpoint) already use S.library.* keys.

What changes

  • web/src/i18n/en.ts — adds feedPlaceholder: "https://your-service/utopia-feed"
  • web/src/i18n/zh.ts — adds feedPlaceholder: "https://your-service/utopia-feed" (same value, it is a URL)
  • web/src/pages/Library.tsx — replaces the hardcoded string with S.library.feedPlaceholder

How it was checked

  • pnpm build and pnpm test pass locally and in CI
  • Placeholder text is visually identical (same string, now from i18n)

Before review

  • Every commit is signed off (git commit -s)
  • For changes under web/: pnpm build and pnpm test pass
  • UI strings are in both web/src/i18n/en.ts and zh.ts

Signed-off-by: Zhoulu <ldazzh@lineadirecta.es>

@WaylandYang WaylandYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome. A small, clean change: the last literal string in that modal now comes from the bundle like its neighbours. CI is green.

Merging. Thanks again.

@WaylandYang
WaylandYang merged commit ff87e80 into deeplethe:dev Oct 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants