Repository navigation
A human phrase decision materializes ahead of queued model work - #1358
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Signed-off-by: Aschenbath <Aschenbath@users.noreply.github.com>
WaylandYang
requested changes
Oct 22, 2026
WaylandYang
left a comment
Contributor
There was a problem hiding this comment.
The change itself is right: CREATE OR REPLACE on the immutable function leaves stale index keys, REINDEX INDEX rebuilds them and is safe inside the migration transaction, and the handler makes no model call. Two things:
- Migration number: 0118 is also claimed by #1334, which is older and about to land. Renumber this to 0119 and update the two
include_str!paths injobs_claim_tests.rs(lines ~44 and ~66) that name the file; the CLI schema count follows whatever the file count is at merge time. - Commit message: one English sentence, no
fix:prefix, and the same sentence as the PR title. The test filetests/a_sync_runs_while_model_work_holds_every_slot.rsnow holdsintake_runs_while_…; rename the file to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A person’s phrase decision queues
materialize_typed, but that store-only job currently waits behind extraction and cannot use the two worker slots reserved for intake.Closes #1351.
What changes
materialize_typedas intake and rebuild the priority index so existing queued jobs receive the new priority.How it was checked
On Linux x86_64 with Rust 1.99.1 and PostgreSQL 16.15, for commit
0f90734:cargo fmt --all --checkcargo clippy --locked --workspace --all-targets -- -D warningscargo test --locked --workspace: 1,653 passed, 0 failed, 6 existing ignored tests, withUTOPIA_DATABASE_URL,UTOPIA_TEST_REQUIRE_DB=1,UTOPIA_TEST_REQUIRE_PDFTOTEXT=1andRUST_TEST_THREADS=1set against a freshly migrated UTF-8 database.REINDEXreturned no eligible queued materialization; the complete migration returnedmaterialize_typed.Before review