Repository navigation
A same verdict that touches an identity entity waits for a person, so a small model cannot merge a source's identities (#1248) - #1364
Merged
WaylandYang merged 2 commits intoOct 22, 2026
Conversation
… a small model cannot merge a source's identities (deeplethe#1248) Signed-off-by: Quintin Botes <quintinbotes@outlook.com>
WaylandYang
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1248: the revision of 0071 asked for there, so the merge side can land after #1333.
Why
0071 decision 1 says #1248 decides the merge side with the same per-source flag, and the record had no decision for it. With governance off, a
sameverdict atAUTO_CONFmerges whatever the source said about its names; #1248 measured what that does on a small local model.What changes
Docs only, in
0071-a-source-may-declare-its-names-identities.md:sameverdict at or aboveAUTO_CONFon a pair where either side is an identity entity (a name fact with evidence from an identity source, the join decision 4 uses) is escalated withescalate_identityinstead of merged, on both paths that apply a verdict (apply_verdictwith governance off, the second look included, andapplyingovernance.rs). It reuses the execution gate's escalation (0027).keptverdicts still close; a person's merge is unchanged.auto_merge: falsethat Let a knowledge base turn off automatic entity merges, independent of governance #1248 first asked for, and closingsamebetween two identity names as kept (two producers can push one thing under two names).a_same_verdict_on_an_identity_entity_waits_for_a_person.How it was checked
Read against
dev:apply_verdictinadjudication.rs(theescalate_impactbranch this reuses) andapplyingovernance.rs. No code changes here.Before review
git commit -s)