Skip to content

docs: drop OpenAIGenerator comparison from tutorial 40 - #487

Merged
bilgeyucel merged 1 commit into
mainfrom
docs/tutorial-40-drop-generator-comparison
Sep 3, 2026
Merged

docs: drop OpenAIGenerator comparison from tutorial 40#487
bilgeyucel merged 1 commit into
mainfrom
docs/tutorial-40-drop-generator-comparison

Conversation

@julian-risch

Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • Tutorial 40, "Learning about the OpenAIChatGenerator": drop the sentence contrasting OpenAIChatGenerator with OpenAIGenerator and the link to the "Generators vs Chat Generators" guide. OpenAIGenerator was removed in Haystack 3.0 and the guide no longer exists.
  • This was the only mention of a removed non-chat Generator in the tutorials repo (searched for the core generators removed in 3.0 and the core-integration generators being removed now).

How did you test it?

Markdown-only change in one cell; the notebook was not re-executed. Validated the notebook JSON and ran pre-commit run --files on it (black-jupyter, check-ast: passed). index.toml needs no change.

Notes for the reviewer

Companion PRs: the core-integration generators are being removed in draft PRs in haystack-core-integrations, docs pages and redirects are handled in deepset-ai/haystack.

Checklist

  • I have read the contributors guidelines
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings — n/a, tutorial prose only
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

OpenAIGenerator was removed in Haystack 3.0, so the sentence contrasting it with
OpenAIChatGenerator and the link to the Generators vs Chat Generators guide no longer apply.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@julian-risch
julian-risch marked this pull request as ready for review September 3, 2026 09:14
@julian-risch
julian-risch requested a review from a team as a code owner September 3, 2026 09:14
@bilgeyucel
bilgeyucel requested review from bilgeyucel and removed request for a team September 3, 2026 09:31
@bilgeyucel
bilgeyucel merged commit 65ccd8c into main Sep 3, 2026
4 checks passed
@bilgeyucel
bilgeyucel deleted the docs/tutorial-40-drop-generator-comparison branch September 3, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants