feat: soft-deprecate stop offering Seqera to new labs - #915
Open
diegomayorga-dept wants to merge 1 commit into
Open
feat: soft-deprecate stop offering Seqera to new labs#915diegomayorga-dept wants to merge 1 commit into
diegomayorga-dept wants to merge 1 commit into
Conversation
First step of the Seqera deprecation: stop offering the "Enable Seqera Integration" toggle and its dependent fields (endpoint URL, workspace ID, access token) in EGFormLabDetails.vue for any lab that doesn't already have NextFlowTowerEnabled = true. Labs that already have Seqera enabled keep seeing and using the section exactly as before. Investigation confirmed no back-end/CDK change is needed: create-laboratory lambda never auto-grants a SEQERA workflow-access row, so not offering the toggle in the UI is sufficient. Updates Labs_Org_Admin.spec.e2e.ts to drop the now-hidden Seqera steps from the create/update lab E2E tests.
diegomayorga-dept
force-pushed
the
feat/seqera-soft-deprecate-new-labs
branch
from
August 25, 2026 15:45
fb8b123 to
5dc607c
Compare
diegomayorga-dept
requested review from
Ignacio Nistal (ignacionistal) and
Kevin Loftus (kevin-loftus-dept)
August 25, 2026 15:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
First step of the Seqera deprecation (team decision, 2026-08-06): stop offering Seqera as an option for labs that don't already have it enabled, without touching anything for labs that already have it.
In
EGFormLabDetails.vue, added a computedisSeqeraAlreadyEnabled— true only when the lab's server-loaded snapshot (uneditedLabDetails) already hadNextFlowTowerEnabled === true. It's based on the loaded snapshot rather than the live toggle so an admin unchecking Seqera on an already-enabled lab doesn't lose the section mid-edit. This gates:<section>(toggle + Endpoint URL + Workspace ID + Personal Access Token fields).Scope note: this hides the section for any lab without Seqera already enabled — new labs and any pre-existing lab that never turned it on — not just brand-new creations, per the ticket body's literal wording (confirmed with the requester).
Investigation (ticket's second part): confirmed no back-end/CDK/schema change is needed.
create-laboratory.lambda.tsnever callsLaboratoryWorkflowAccessService— no SEQERA workflow-access row is auto-granted to new labs today; per-workflow ALLOW/DENY rows are only created when an org admin explicitly edits the Workflow Access allowlist. So not offering the toggle in the UI is sufficient.Also updated
Labs_Org_Admin.spec.e2e.ts: removed the Seqera-toggle steps from the create/update lab E2E tests, since the lab they exercise no longer has Seqera enabled.Out of scope: removing Seqera back-end code, CDK resources, or shared-lib types/schemas (separate hard-removal epic); any change to labs that already have Seqera enabled.
Testing
pnpm --filter front-end test— 129/129 tests passing, 0 lint errors (no regressions; no dedicated component test exists forEGFormLabDetails.vue, consistent with this repo's convention of front-end unit tests covering onlyapp/utils/pure functions).TESTING.mdas "Not yet executed," pending a manual pass against a deployed environment.Labs_Org_Admin.spec.e2e.tssteps have not been run — Playwright E2E runs against a deployedqualityenvironment, not locally.Impact
Front-end only, presentation-level change (Vue template/computed logic in one component, plus its E2E test). No back-end, CDK, schema, or API changes. No new dependencies. No behavior change for labs that already have
NextFlowTowerEnabled = true.Additional Information
None.
Checklist