Skip to content

feat: soft-deprecate stop offering Seqera to new labs - #915

Open
diegomayorga-dept wants to merge 1 commit into
developmentfrom
feat/seqera-soft-deprecate-new-labs
Open

feat: soft-deprecate stop offering Seqera to new labs#915
diegomayorga-dept wants to merge 1 commit into
developmentfrom
feat/seqera-soft-deprecate-new-labs

Conversation

@diegomayorga-dept

Copy link
Copy Markdown
Contributor

Type of Change

  • New feature

Description

First step of the Seqera deprecation (team decision, 2026-08-06): stop offering Seqera as an option for labs that don't already have it enabled, without touching anything for labs that already have it.

In EGFormLabDetails.vue, added a computed isSeqeraAlreadyEnabled — true only when the lab's server-loaded snapshot (uneditedLabDetails) already had NextFlowTowerEnabled === true. It's based on the loaded snapshot rather than the live toggle so an admin unchecking Seqera on an already-enabled lab doesn't lose the section mid-edit. This gates:

  • The whole "Enable Seqera Integration" <section> (toggle + Endpoint URL + Workspace ID + Personal Access Token fields).
  • The "Seqera On/Off" badge on the Integrations card header.
  • The Integrations card's description text and the AI Failure Analysis empty-state hint, so neither still mentions Seqera when it isn't offered.

Scope note: this hides the section for any lab without Seqera already enabled — new labs and any pre-existing lab that never turned it on — not just brand-new creations, per the ticket body's literal wording (confirmed with the requester).

Investigation (ticket's second part): confirmed no back-end/CDK/schema change is needed. create-laboratory.lambda.ts never calls LaboratoryWorkflowAccessService — no SEQERA workflow-access row is auto-granted to new labs today; per-workflow ALLOW/DENY rows are only created when an org admin explicitly edits the Workflow Access allowlist. So not offering the toggle in the UI is sufficient.

Also updated Labs_Org_Admin.spec.e2e.ts: removed the Seqera-toggle steps from the create/update lab E2E tests, since the lab they exercise no longer has Seqera enabled.

Out of scope: removing Seqera back-end code, CDK resources, or shared-lib types/schemas (separate hard-removal epic); any change to labs that already have Seqera enabled.

Testing

  • pnpm --filter front-end test — 129/129 tests passing, 0 lint errors (no regressions; no dedicated component test exists for EGFormLabDetails.vue, consistent with this repo's convention of front-end unit tests covering only app/utils/ pure functions).
  • Pre-commit hook ran shared-lib OpenAPI regen + the full back-end test suite (109 suites / 802 tests) — all passing, since this change touches no back-end code but the hook runs regardless.
  • Not yet verified: the two manual QA cases (new lab shows no Seqera section; existing Seqera-enabled lab is unchanged) are logged in TESTING.md as "Not yet executed," pending a manual pass against a deployed environment.
  • The updated Labs_Org_Admin.spec.e2e.ts steps have not been run — Playwright E2E runs against a deployed quality environment, not locally.

Impact

Front-end only, presentation-level change (Vue template/computed logic in one component, plus its E2E test). No back-end, CDK, schema, or API changes. No new dependencies. No behavior change for labs that already have NextFlowTowerEnabled = true.

Additional Information

None.

Checklist

  • No new errors or warnings have been introduced.
  • All tests pass successfully and new tests added as necessary. (automated front-end/back-end suites pass; the two manual QA cases and the E2E update are not yet executed — see Testing)
  • Documentation has been updated accordingly. (N/A — QA notes added to TESTING.md; no user-facing docs affected)
  • Code adheres to the coding and style guidelines of the project.
  • Code has been commented in particularly hard-to-understand areas.

@diegomayorga-dept diegomayorga-dept changed the title [Seqera] Soft-deprecate: stop offering Seqera to new labs feat: soft-deprecate stop offering Seqera to new labs Aug 25, 2026
First step of the Seqera deprecation: stop offering the "Enable Seqera
Integration" toggle and its dependent fields (endpoint URL, workspace ID,
access token) in EGFormLabDetails.vue for any lab that doesn't already
have NextFlowTowerEnabled = true. Labs that already have Seqera enabled
keep seeing and using the section exactly as before.

Investigation confirmed no back-end/CDK change is needed: create-laboratory
lambda never auto-grants a SEQERA workflow-access row, so not offering the
toggle in the UI is sufficient.

Updates Labs_Org_Admin.spec.e2e.ts to drop the now-hidden Seqera steps from
the create/update lab E2E tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant