Repository navigation
fix(ci): build image on published release instead of tag push - #96
Merged
Merged
Conversation
The release workflow only fires on changes to app/ or Dockerfile, so dependency bumps from Dependabot never published a new image even though Pipfile.lock goes into the build. Add both Pipfile files to the paths filter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Iván Alejandro Marugán <hello@ialejandro.rocks>
docker-build.yml listens for push on v* tags, but semantic-release creates the tag through the releases API and no run ever starts (v1.22.1 has none). Trigger on the published release event instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Iván Alejandro Marugán <hello@ialejandro.rocks>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-build.ymlescuchapushde tagsv*, pero semantic-release crea el tag y la release por la API y ese workflow no tiene ningún run (v1.22.1 tampoco). Lo cambio arelease: types: [published], que es el evento que usa el resto de repos de la org y que sí se emite con el PAT que ya usa el workflow de release.No lo he podido probar antes del merge. Para validarlo sin esperar: tras el merge, lanzar
docker-build.ymla mano para v1.22.1, o esperar a la siguiente release.