Repository navigation
feat: add a JavaFX VideoView - #403
Merged
Merged
Conversation
The node shows client API video in JavaFX scenes, as the Swing VideoView does in Swing: frames are converted on their own thread and painted at most once per pulse, with aspect ratio, rotation and mirroring. The module compiles for Java 11, since OpenJFX does, and takes JavaFX as an optional dependency. It is published with the other modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#401 was merged into
feat/client-apiafter that branch had already been merged, so it never reachedmain. This brings the same commit tomain.webrtc-java-javafxmodule (JPMSwebrtc.java.javafx, Java 11) withdev.onvoid.webrtc.client.javafx.VideoView, the JavaFX counterpart of the SwingVideoView. OpenJFX is an optional dependency.