Repository navigation
fix: harden data channel sends and runtime close - #408
Merged
Merged
Conversation
… data channel sends sendByteArrayBuffer used the result of GetByteArrayElements unchecked and built the buffer outside the catch; both sync paths now follow the async ones.
A close that leaks the factory to protect WebRTC's threads no longer completes normally, so callers can tell it from a full release.
PeerOptions.channelSendLimit (16 MiB by default) caps the bytes each channel holds in Java; a send beyond it fails at once with a ChannelFullException.
devopvoid
marked this pull request as ready for review
October 21, 2026 23:12
# Conflicts: # webrtc/src/main/java/dev/onvoid/webrtc/client/WebRtc.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebRtc.closeAsync()fails when the factory is left undisposed instead of completing normally.PeerOptions.channelSendLimit(16 MiB by default) bounds what a data channel holds in Java; sends beyond it fail withChannelFullException.