Repository navigation
fix: bound AudioResampler buffers and keep cropped I420 buffers alive - #413
Merged
Merged
Conversation
AudioResampler passed the output array's capacity instead of the requested samples per channel and ignored the channel count, so stereo wrote past the array. Both arrays are now checked against samplesPerChannel * channels. Cropping a NativeI420Buffer without scaling returned a wrapper with no native handle over the source's memory. The crop is now a native buffer that holds a reference to its source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioResamplerpassed the output array's capacity to native code instead of the requested samples per channel and ignored the channel count, so stereo wrote past the array. Both arrays are now checked againstsamplesPerChannel * channels, with WebRTC's limits on samples and channels, and the native side checks them again. The class also loads the native library itself.NativeI420Buffer.cropAndScalewithout scaling returned a wrapper with no native handle over the source's memory. The crop is now a native buffer (WrapI420Buffer) that holds a reference to its source. Plane views end at the last pixel, crop rectangles are validated, and a released buffer in aVideoFramethrows instead of reaching native code as null.