Repository navigation
fix: guard track creation and report failed track releases - #414
Merged
Merged
Conversation
The runtime takes a control pool and a timer through package-private builder methods, so tests step through control tasks and fire timeouts themselves. createPeer is split into register and open, the points a closing runtime can meet it at. New tests cover SerialExecutor rejection, createPeer against close at each point, answers that arrive after the session timed out, and how close failures are reported; the HTTP test endpoint holds answers on a latch instead of sleeping.
Track creations register before touching the factory, so a closing runtime waits for them. A failed track release still runs its remaining steps and fails the track's and the runtime's close.
# Conflicts: # webrtc/src/test/java/dev/onvoid/webrtc/client/RuntimeCloseTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalMediaImplregister before they touch the factory, so a closing runtime waits for them and closes what they made before it frees the factory.LocalTrackImpl.release()tries every release step, fails the track'scloseAsync()when one fails, and keeps the track so that the runtime's close fails and leaves the factory undisposed.