Repository navigation
fix: load the native library for classes used on their own - #417
Merged
Merged
Conversation
NativeObject loads the library before any class that wraps a native object is used, and VideoBufferConverter and PowerManagement load it themselves. A test uses each such class in a fresh JVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NativeObjectloads the native library, so every class that wraps a native object has it before its first native call, also when an application uses it without aPeerConnectionFactory, such asAudioConverter,CustomAudioSource,CustomVideoSource,NativeI420BufferorVideoCapture.VideoBufferConverterandPowerManagement, which do not extend it, load it themselves.StandaloneLoadingTestsuses each such class in a fresh JVM, since in the JVM the other tests share an earlier test has always loaded the library.