Repository navigation
fix: bound received data channel messages before they are queued - #418
Merged
Merged
Conversation
Received messages count against a new PeerOptions channelReceiveLimit (16 MiB by default) from the moment they arrive until the handlers are done with them, including those kept while a channel has no handler. A channel that goes over it closes and reports why, instead of growing the event queue or dropping messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PeerOptions.Builder.channelReceiveLimit(16 MiB by default) from the moment they arrive, before they are queued for the handlers, until the handlers are done with them. Messages kept while a channel has no handler count as well.onErrorhandlers hear why, instead of letting the event queue grow without bound or dropping messages of a reliable channel. This replaces dropping the oldest messages kept without a handler.