Repository navigation
fix: count AudioConverter sizes over all channels and bound them natively - #421
Merged
Merged
Conversation
…vely The resampling path took the total sample counts from Java as samples per channel, so stereo read and wrote twice a frame past the arrays. All converters now count samples over all channels, and the views use the configured frames. convertInternal is private and checks the arrays and counts itself; invalid formats, including remixes too large for an AudioFrame, throw IllegalArgumentException instead of aborting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resampling path of
AudioConvertertook Java's total sample counts as samples per channel, so stereo with a changed sample rate read and wrote a frame past the arrays. All converters now count samples over all channels.convertInternalis private and checks its arrays and counts natively. Invalid formats, including remixes too large for anAudioFrame, throwIllegalArgumentExceptioninstead of aborting.