feat(site-kit): brandIconLinks — one head link set for the linq-brand icons (D-026) - #61
Merged
Merged
Conversation
… icons (D-026)
AskLinq's search result was still showing the icon from before the mark
changed (D-125, ten days earlier). The production files were already the
new mark; the page head had no <link rel="icon"> at all since the
web-next cutover, so crawlers saw only the /favicon.ico fallback, and that
file was a 32px PNG — under Google's "preferably >48x48px". Checking the
siblings: VisionLinq, BookLinq, TraceLinq and AskLinq each linked a
different subset of the same @devslab/linq-brand files.
`brandIconLinks({ basePath })` is now the one place that says which files
a head links and in what order: favicon.svg first, mark-48.png (48x48),
favicon.ico (16/32/48), apple-touch-icon.png (180x180). `BRAND_ICON_FILES`
names the same four so a product serves them from one directory.
`toTanStackHead(metadata, { icons })` appends them — opt-in, because the
adapter cannot know where a product serves the files and a head that
links icons the server 404s is worse than one that links none. basePath
is a same-origin path; a URL is a RangeError.
Tests: link set and order, base-path handling, adapter appends after the
alternates only when asked. README en/ko, changeset (minor), D-026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AskLinq's Google result still showed the pre-D-125 question-mark icon ten days after the mark changed. The served files were already the new mark; the causes were a missing
<link rel="icon">(dropped in the web-next cutover) and a 32px-only/favicon.ico(Google: "at least 8x8px, preferably >48x48px"). Looking across the family, four sites linked four different subsets of the same@devslab/linq-brandfiles.What
brandIconLinks({ basePath = "/brand" })→ the fixed four-link set:favicon.svg,mark-48.png(48x48),favicon.ico(16/32/48),apple-touch-icon.png(180x180).BRAND_ICON_FILES— the same four names, so a product serves them from one directory.toTanStackHead(metadata, { icons: true | { basePath } })appends them. Opt-in; omitted, output is byte-identical to before.basePathmust be a same-origin path (URL →RangeError): a product serves its own icons.Verify
pnpm run verify(build + check) green,verify:source:stage3-40 fail (3 new tests insite-kit-core).getasklinq.apphead +/brand/*routes) follows in devslab-kr/asklinq once this is published.왜
AskLinq 구글 검색 결과의 파비콘이 마크 교체(D-125) 열흘 뒤에도 옛 물음표였다. 서빙 파일은 이미 새 마크였고, 원인은 web-next 컷오버에서 빠진
<link rel="icon">과 32px뿐인/favicon.ico(구글 권장 48px 초과). 가족 사이트 넷이 같은@devslab/linq-brand파일을 네 가지 조합으로 링크하고 있었다.무엇
brandIconLinks({ basePath = "/brand" })— 고정된 네 링크.BRAND_ICON_FILES가 같은 네 파일명.toTanStackHead(metadata, { icons })가 옵트인으로 덧붙인다. 생략 시 출력은 이전과 바이트 동일.basePath는 같은 오리진 경로만(URL은RangeError).