Skip to content

fix(bags): restore Forever category icons - #4

Closed
dfrisone wants to merge 13 commits into
mainfrom
fix/forever-bags-missing-category-icons
Closed

dfrisone wants to merge 13 commits into
mainfrom
fix/forever-bags-missing-category-icons

Conversation

@dfrisone

Copy link
Copy Markdown
Owner

What does this PR do?

Restores the Gear Enhancements and Professions category icons on the Forever client. The Bags sidebar now resolves category texture IDs through a Forever-only fallback map; Retail retains its original texture IDs.

How was it tested?

  • Parsed both changed Lua files with the local Lua interpreter.
  • Passed the diff-scoped style gate, whitespace check, and locale-key extraction.
  • Verified the active Forever port resolves the same category IDs through the fallback at the sidebar render point.
  • In-game verification has not been run.

Screenshots

Missing: no before/after client screenshots were captured.

Checklist

  • New settings default OFF (no behavior change without opt-in) - N/A; no setting added
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built - N/A; no feature lifecycle added
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added (unverified: Forever client test pending)

LGTM

@dfrisone

Copy link
Copy Markdown
Owner Author

Reopened against the upstream repo as EllesmereGaming#2134. This one targeted the fork by mistake.

@dfrisone dfrisone closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants