Skip to content

CMake: Add SDFTD3_INSTALL_FMODDIR - #239

Merged
awvwgk merged 2 commits into
dftd3:mainfrom
Growl1234:cmake
Oct 22, 2026
Merged

awvwgk merged 2 commits into
dftd3:mainfrom
Growl1234:cmake

Conversation

@Growl1234

@Growl1234 Growl1234 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

This is mainly for convenience of Fedora packaging as it requires Fortran modules to be installed under %{fmoddir}.

Note: We shouldn't simply adopt what's done for mctc-lib etc:

set(
  "${PROJECT_NAME}-module-dir"
  "${PROJECT_NAME}/modules"
  CACHE STRING
  "Subdirectory to install generated module files to"
)
set(
  module-dir
  "${${PROJECT_NAME}-module-dir}"
)
set(module-dir "${module-dir}" PARENT_SCOPE)

Downstream sets CMAKE_INSTALL_INCLUDEDIR to %{_lib}/gfortran/modules as a workaround, which is not applicable to s-dftd3 as it has public C header. This is also an issue on dftd4 and tblite side; will fix them soon (update: dftd4/dftd4#405, tblite/tblite#415).

@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.45%. Comparing base (5bf48d7) to head (0b84317).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   63.49%   63.45%   -0.04%     
==========================================
  Files          47       47              
  Lines        6821     6855      +34     
  Branches     2422     2438      +16     
==========================================
+ Hits         4331     4350      +19     
- Misses       1182     1191       +9     
- Partials     1308     1314       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Growl1234
Growl1234 force-pushed the cmake branch 3 times, most recently from 2b7b939 to 89ded45 Compare October 12, 2026 16:24
@Growl1234

Copy link
Copy Markdown
Contributor Author

Hi, could we move this forward?

@awvwgk
awvwgk merged commit 56a4126 into dftd3:main Oct 22, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants