Repository navigation
Accelerate Ewald calculation - #244
Merged
Merged
Conversation
Growl1234
force-pushed
the
ewald
branch
3 times, most recently
from
October 21, 2026 14:15
ef03af8 to
ef76de1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 63.43% 63.45% +0.02%
==========================================
Files 47 47
Lines 6831 6855 +24
Branches 2422 2438 +16
==========================================
+ Hits 4333 4350 +17
- Misses 1190 1191 +1
- Partials 1308 1314 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
GitHub has started updating `ubuntu-latest` to 26.04 but not yet done...
Contributor
Author
|
Side note:
Now this PR should be ready. There maybe follow-up work worth considering, but I don't expect it to bring significant performance improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the supplied 576-atom cell with
OMP_NUM_THREADS=24 ./s-dftd3 1.xyz --zero pbe --grad --ewald, wall time has decreased from96.536 sto2.726 s.