Skip to content

Add missing rmarkdown vignette dependency for linux R-devel checks - #27

Merged
dicook merged 2 commits into
masterfrom
copilot/fix-linux-r-devel-job-failure
Sep 26, 2026
Merged

dicook merged 2 commits into
masterfrom
copilot/fix-linux-r-devel-job-failure

Conversation

Copilot AI commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

The linux (R-devel) GitHub Actions job was failing during vignette rebuilds because the package metadata did not declare rmarkdown, even though the package ships multiple *.Rmd vignettes. This change aligns DESCRIPTION with the actual vignette toolchain so CI installs the required package.

  • Root cause

    • Vignette rebuilds in CI failed with there is no package called 'rmarkdown'
    • The package includes R Markdown vignettes under vignettes/, but DESCRIPTION only listed knitr in Suggests
  • Change

    • Add rmarkdown to Suggests in DESCRIPTION
    • Leave the existing VignetteBuilder: knitr configuration unchanged
  • Effect

    • Ensures environments performing package checks and vignette builds install the full R Markdown dependency set
    • Removes the metadata gap that caused linux (R-devel) to fail
Suggests:
    forecast,
    viridis,
-   knitr
+   knitr,
+   rmarkdown

Co-authored-by: dicook <253191+dicook@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job linux (R-devel) Add missing rmarkdown vignette dependency for linux R-devel checks Sep 26, 2026
Copilot AI requested a review from dicook September 26, 2026 01:46
@dicook
dicook marked this pull request as ready for review September 26, 2026 01:50
Copilot AI lite review requested due to automatic review settings September 26, 2026 01:50
@dicook
dicook merged commit 1a16d70 into master Sep 26, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The metadata change addresses the missing CI dependency without introducing unresolved issues.

Review effort: Lite
Findings: None

What changed in this PR

Adds the missing rmarkdown dependency for R Markdown vignette builds and R-devel CI checks.

Changes:

  • Adds rmarkdown to Suggests.
  • Preserves VignetteBuilder: knitr.
File Description
DESCRIPTION Declares the required vignette dependency.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants