feat: final parity changes with MATLAB#205
Open
john-halloran wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 77.50% 74.28% -3.22%
==========================================
Files 3 3
Lines 40 35 -5
==========================================
- Hits 31 26 -5
Misses 9 9 🚀 New features to boost your workflow:
|
sbillinge
reviewed
Jun 25, 2026
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
please see comments. @john-halloran I will merge, but please act on the comments if you can.
| Maximum number of projected-gradient stretch steps per outer-loop | ||
| iteration. Optional. | ||
| stretch_slow_iter : int | ||
| Number of initial outer-loop stretch updates to solve with the |
Contributor
There was a problem hiding this comment.
Don't change any of these, but moving forward, please use the group standard that descriptions start with "The". In most cases "The" can just be added at the beginning of the existing description. But as I said, don't bother fixing this here, just use the pattern moving forward.
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder, will do.
Contributor
|
@john-halloran this needs conflict resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR that brings parity (when other open PRs also merged) with MATLAB on a few remaining points. Since we now converge just as fast, we can use fewer iterations. We can also switch to a faster path when possible, and log the objective function.