Support partial matching in DCQL and override delegation for user verification - #56
Merged
QZHelen merged 1 commit intoSep 17, 2026
Conversation
danieljkim1
force-pushed
the
pnv-matcher-delegation
branch
3 times, most recently
from
September 16, 2026 22:33
3fd2c64 to
8b58213
Compare
|
PnvOpenID4VPMatcherTest also passes fully |
QZHelen
reviewed
Sep 17, 2026
QZHelen
left a comment
QZHelen
left a comment
Contributor
There was a problem hiding this comment.
Please also update the pnv.wasm used by CMWallet
| return 1; | ||
| } | ||
| } | ||
| cJSON *cred_uv_hint = cJSON_GetObjectItemCaseSensitive(cred, "user_verification_hint"); |
Contributor
There was a problem hiding this comment.
This (user_verification_hint ) is the only valid hint value, and there's no true/false or other values associated with it
- Allow partial credential matching across credential sets in DCQL for PNV matcher - Define SetDelegationTypeForEntryInSet in credentialmanager.h - Forward delegation_type from candidate credentials through dcql matching - Set delegation (type 1) when wasm_version >= 7 and candidate delegation_type is FULL (1) without user verification - Suppress partial matches when user verification is requested, delegation is unsupported (wasm_version < 7), or candidate delegation_type is not FULL (1) - Match user_verification_hint claim path inside dcql_query claims to detect UV request - Modernize PNV test framework and add unit test coverage for hint matching, full match delegation, UV suppression, and partial match filtering - Update pnv.wasm asset used by CMWallet - Add pnv_test and test_pnv targets to matcher/Makefile
danieljkim1
force-pushed
the
pnv-matcher-delegation
branch
from
September 17, 2026 01:08
b5b036c to
7dab12e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matched_indices,option_length, andis_partial.SetDelegationTypeForEntryInSet(credman_v7) tomatcher/credentialmanager.h.wasm_version >= 7, default delegation type to1(FRAGMENT).user_verification,user_verification_hint,expected_user_verificationin request parameters or DCQL credential/claim paths), override delegation type to0(NONE).NONEensures Credential Manager invokes the provider Activity (e.g.OgiTokenPresentationChimeraActivity) rather than the headless background fulfillment service, so user authentication (biometrics/PIN/device lock) can be performed.