chore: client release assets, deploy var guard, import fixes - #11
Merged
Merged
Conversation
- publish-client.yaml attaches the packed tarball and SHA256SUMS to the GitHub release for each client-v* tag so vendored copies can be traced to a build; client/README.md documents how consumers vendor and verify. - deploy-infra.sh refuses required values containing whitespace or a literal backslash-n; one such value put a 66-char header into the test Function while APIM held the 64-char value, and every gateway route answered 401. - import-penguin-history.js: push rows in a loop (spread overflowed the stack at 330k rows), map penguin event names to the client's names, and import only names the products emit; penguin stored free-text event names and 148 of 178 distinct prod values were injection payloads. - Direct unit tests for src/auth/origin.js and src/auth/safe-equal.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub release for each client-v* tag so vendored copies can be traced
to a build; client/README.md documents how consumers vendor and verify.
literal backslash-n; one such value put a 66-char header into the test
Function while APIM held the 64-char value, and every gateway route
answered 401.
stack at 330k rows), map penguin event names to the client's names,
and import only names the products emit; penguin stored free-text
event names and 148 of 178 distinct prod values were injection
payloads.