fix(ingest): resolve visitor IP behind APIM - #13
Merged
Merged
Conversation
APIM stamps X-Client-Ip and appends nothing to X-Forwarded-For, so the last hop is the one Azure's Functions front end added for APIM itself. Reading that hop located every event in Toronto and put the whole OpenShift cluster in one rate-cap bucket, which is what gave eagle-api 429 bursts on prod. The visitor is the hop before it, read only when X-Client-Ip is an address in TRUSTED_PROXY_IPS: APIM sets that header with override and every route here sits behind the gateway guard, so a caller cannot forge it. A caller with no hop of its own is a server producer sharing the cluster's egress address with every browser behind it, and is exempt from the cap rather than sharing its bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every event geolocated to Toronto and the per-IP cap keyed on one address: the Function took the right-most X-Forwarded-For hop, which is the APIM gateway's outbound address once the Functions front end appends it. Front Door is not in the request path on either env yet, so the X-Azure-FDID branch never fires.
Verified on test with hand-set headers: the Front Door branch already works end to end when the headers arrive.