Repository navigation
ppc: Fix reversed operands in tw opcode implementation - #237
Merged
Merged
Conversation
The manual decode swapped rA and rB. Fix thix by using the standard `ppc_grab_regsab` decode helper. Fixes Macintosh Common Lisp 4.2 hanging at startup (with 7.5.5 booting using the 7500 ROM).
Use existing helpers for more instructions instructions (twi, mtsr, mtmsr, etc.). Prompted by the recent fix for tw - these were all correct already, but might as well make things more uniform.
mihaip
added a commit
to mihaip/infinite-mac
that referenced
this pull request
Oct 11, 2026
Picks up dingusdev/dingusppc#237, which fixes Macintosh Common Lisp. For #219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual decode swapped rA and rB. Fix thix by using the standard
ppc_grab_regsabdecode helper. This fixes Macintosh Common Lisp 4.2 hanging at startup (with 7.5.5 booting using the 7500 ROM).I also audited other manual decodes in
ppcopcodes.cpp- the rest were correct, but I switched them to decode helpers anyway, to make things more uniform.