Skip to content

grandcentral: Keep interrupt events and CPU IRQ state consistent #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dingusdev merged 1 commit into from
Oct 14, 2026
Merged

grandcentral: Keep interrupt events and CPU IRQ state consistent #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions devices/ioctrl/grandcentral.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,7 @@ void GrandCentral::write(uint32_t rgn_start, uint32_t offset, uint32_t value, in
switch (offset) {
case MIO_INT_MASK1:
this->int_mask = BYTESWAP_32(value);
this->clear_cpu_int();
this->signal_cpu_int();
break;
case MIO_INT_CLEAR1:
Expand Down Expand Up @@ -529,9 +530,8 @@ void GrandCentral::ack_int_common(uint64_t irq_id, uint8_t irq_line_state) {
if ((this->int_mask & MACIO_INT_MODE) ||
(irq_line_state && !(this->int_levels & irq_id))) {
this->int_events |= (uint32_t)irq_id;
} else {
this->int_events &= ~(uint32_t)irq_id;
}
// Events remain latched until software writes InterruptClear.

// update IRQ line state
if (irq_line_state) {
Expand Down
Loading