Move NQ ordering to database - #1289
Merged
Merged
Conversation
donaldgray
marked this pull request as ready for review
August 24, 2026 09:26
JackLewis-digirati
approved these changes
Aug 24, 2026
Initial change was to add ordering to /raw-resource/ endpoint. This lead to realising reordering is happening in memory and can be moved to DB, fluently in DB call. This should be more performant than in-memory. Null handling differs between DB + memory but in practice this is not an issue as all orderable fields are non-null in db.
donaldgray
force-pushed
the
bugfix/raw_resource_ordering
branch
from
August 24, 2026 14:23
7017ed1 to
ba73bf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #1285
Initial change was to add ordering to /raw-resource/ endpoint. This lead to realising reordering is happening in memory and can be moved to DB, fluently in DB call.
This should be more performant than in-memory. Null handling differs between DB + memory but in practice this is not an issue as all orderable fields are non-null in db.