Adjunct POST: advertise the HydraCollection response only (single-Adjunct annotations were never produced) - #1292
Merged
Merged
Conversation
…ways returns a HydraCollection) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sQRpZ5sSddRoFLdHHrHdz
donaldgray
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
POST /customers/{c}/spaces/{s}/images/{i}/adjunctsis annotated as returning either aHydraCollection<Adjunct>or a singleAdjunct(200/201 each), and its XML doc comment says "or a HydraCollection if more than 1 submitted". The implementation does not do that:BuildHydraResponseinAdjunctsControlleralways wraps the result in aHydraCollection, even when a single adjunct was POSTed (only PUT returns a bareAdjunct). Verified on the current stage deployment — a single-member POST returns{ "@type": "Collection", "totalItems": 1, "member": [ ... ] }.This PR removes the two single-
AdjunctProducesResponseTypeattributes from the POST action and corrects the doc comment, so Swagger/OpenAPI describes the response the endpoint actually produces. No behaviour change — annotation and comment only. The public API docs (dlcs/public-docs, adjuncts page) are being updated in step to state that POST always returns a collection.No database, infrastructure, configuration or breaking changes.