Skip to content

Don't trap on an unknown AVSpeechSynthesisVoiceGender #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronjb wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Don't trap on an unknown AVSpeechSynthesisVoiceGender #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ios/Classes/SwiftFlutterTtsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@ extension AVSpeechSynthesisVoiceGender {
return "female"
case .unspecified:
return "unspecified"
@unknown default:
// AVSpeechSynthesisVoiceGender is an Objective-C enum, so a voice
// can report a case this build was not compiled against. Without
// this the switch traps and takes the whole app down.
return "unspecified"
}
}
}
5 changes: 5 additions & 0 deletions macos/Classes/FlutterTtsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,11 @@ extension AVSpeechSynthesisVoiceGender {
return "female"
case .unspecified:
return "unspecified"
@unknown default:
// AVSpeechSynthesisVoiceGender is an Objective-C enum, so a voice
// can report a case this build was not compiled against. Without
// this the switch traps and takes the whole app down.
return "unspecified"
}
}
}