Specify a few invalid configuration options to avoid potential confusion for the users - #22
Open
KristianHMoller wants to merge 3 commits into
Open
Conversation
KristianHMoller
requested review from
helenbr and
khintz
and
a lite review from Copilot
and removed request for
khintz
August 21, 2026 07:24
Collaborator
Author
|
@JoachimKoenigslieb if you have the time, could you check that things still work for you with this small update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option of using climatological clear-sky values was introduced with #15. This is currently incompatible with
run_mode=download. This limitation is now made clear in the suite.Additionally, download is currently only implemented for the KNMI and DWD (disabled) datasets. To avoid potential confusion if adding new datasets, this is made clear.
Finally, a small bug has been fixed where clear-sky was called with
domain_nowcastrather thandomain_satellite.