Conversation
…efore rendering Some users have seen the "Heads up!" explainer, understand the choice it explains, and want the note gone altogether: "Got it" only ever collapsed it to a "Multiple accounts used" caption that never ended, so every shared-site confirm carried a line they had long stopped reading. The card carries a second, quiet answer now — "Don't show this again" — which writes sharedHeadsUpOptOut to the same chrome.storage.local both surfaces read (per-browser UI state, not account data, so the prompt windows can read it without unlocking). Opted out, neither the explainer nor the caption renders; the confirm itself and its account picker are untouched, because the opt-out answers the explanation, never the question it explains. The way back is a restorer in Settings → Apps & browsing that clears both flags, so the one-time explainer returns as if never seen. On the way past, the race: both flags load together and the render awaits them, where the async single-flag read used to repaint a dismissed explainer because a confirm rendered before the read landed. Fixes #340.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #340. Independent of the composer stack (#341 → #356); based on
main.What
sharedHeadsUpOptOuttochrome.storage.local(per-browser UI state, deliberately not the encrypted settings store — the prompt windows read it without unlocking).renderSharedNoteawaits them — the old async single-flag read could repaint a dismissed explainer when a confirm rendered before the read landed.8 new tests in
test/shared-headsup-optout.test.jscover both surfaces symmetrically. Note for review: this composes with #349 (per-host opt-out of the confirm itself) — #349's opt-out takes precedence where set; this one only silences the note.