Skip to content

match Sound (to what i could), start SoundManager - #50

Open
abnormalhare wants to merge 7 commits into
doldecomp:mainfrom
abnormalhare:revo
Open

abnormalhare wants to merge 7 commits into
doldecomp:mainfrom
abnormalhare:revo

Conversation

@abnormalhare

Copy link
Copy Markdown
Contributor

I'm probably gonna move away from this project in favor of MWCC decomp, but I've set up the small amount of work i did on SoundManager for future problem solvers

@decomp-dev

decomp-dev Bot commented Oct 22, 2026

Copy link
Copy Markdown

Report for HAFE (8c49e69 - ab4d0a7)

📈 Matched code: 81.29% (+0.03%, +420 bytes)
Total data: 1813674 bytes (-4 bytes)
📈 Matched data: 56.00% (+0.00%, +40 bytes)
📈 Linked data: 81.91% (+0.00%, +4 bytes)

✅ 12 new matches
Unit Item Bytes Before After
main/Sound Sound::Sound(const char*, void*) +128 0.00% 100.00%
main/Sound Sound::~Sound() +112 0.00% 100.00%
main/Sound __sinit_\Sound_cpp +88 0.00% 100.00%
main/SoundManager fn_80041884(void*, void*, void* (*)(unsigned long), void (*)(void*)) +36 0.00% 100.00%
main/Sound .bss +32 0.00% 100.00%
main/Sound __arraydtor$8191 +28 0.00% 100.00%
main/Sound nw4r::snd::SoundHandle::SoundHandle() +12 0.00% 100.00%
main/Sound DefaultSoundAlloc(unsigned long) +8 0.00% 100.00%
main/SimpleGlobe .bss +4 100.00% 100.00%
main/Sound .ctors +4 0.00% 100.00%
main/Sound UpdateSound() +4 0.00% 100.00%
main/Sound CalcSound() +4 0.00% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/SoundManager fn_800418A8(unsigned char, void*, const char*, void*, unsigned long, void* (*)(unsigned long), void (*)(void*)) +347 0.00% 38.15%
main/SoundManager .sbss +53 0.00% 66.67%

Comment thread src/SoundManager.cpp
nw4r::snd::SoundHeap *gSoundHeap = NULL; // 0x50
nw4r::snd::FxReverbHi *gFxReverb = NULL; // 0x6C

void fn_80041884(void* data, void* heap, void* (*alloc_func)(u32), void (*mem_func)(void*)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functions need to be named lol

Comment thread src/SoundManager.cpp
#include "nw4r/snd/snd_SoundHeap.h"
#include "nw4r/snd/snd_SoundSystem.h"

u8 lbl_80330C38 = 0;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnamed label

Comment thread src/SoundManager.cpp
#include "nw4r/snd/snd_SoundSystem.h"

u8 lbl_80330C38 = 0;
u8 lbl_80330C39 = 0;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnamed label

Comment thread src/SoundManager.cpp
SoundMemFunc gMemFunc = 0; // 0x40
void *gMemSoundArchive = NULL; // 0x44
nw4r::snd::SoundArchivePlayer *gArchivePlayer = NULL; // 0x48
u32 *lbl_80330C4C = NULL; // 0x4C, something that inherits SoundArchive...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnamed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants