Skip to content

itFoxBlaster: store shot effects as typed pointers - #3673

Merged
itsgrimetime merged 2 commits into
doldecomp:masterfrom
itsgrimetime:codex/blaster-effect-pointers
Oct 13, 2026
Merged

itsgrimetime merged 2 commits into
doldecomp:masterfrom
itsgrimetime:codex/blaster-effect-pointers

Conversation

@itsgrimetime

Copy link
Copy Markdown
Collaborator

Store the blaster's shot-effect history as EF_Effect*[6]. Both Fox/Falco and Kirby-copy spawn paths return EF_Effect*; storing those results as s32 truncates native pointers. Typed slots remove the narrowing casts and make the history's contents explicit.

Validation: all 1,133 compiled objects and the final DOL remain byte-identical to master. Focused ARM64 -O2 ASan/UBSan checks reproduce lost pointer identity in all four old variants and pass with the correction, including history rollover, null results, adjacent arrays and resets.

@itsgrimetime itsgrimetime added the ai-assisted Utilizes a LLM to do the heavy lifting label Oct 13, 2026
@itsgrimetime
itsgrimetime enabled auto-merge (squash) October 13, 2026 17:20
@itsgrimetime
itsgrimetime merged commit cf8e598 into doldecomp:master Oct 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Utilizes a LLM to do the heavy lifting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant