Skip to content

grAnime: preserve callback pointers and search results - #3674

Merged
itsgrimetime merged 3 commits into
doldecomp:masterfrom
itsgrimetime:codex/stage-animation-pointers
Oct 13, 2026
Merged

itsgrimetime merged 3 commits into
doldecomp:masterfrom
itsgrimetime:codex/stage-animation-pointers

Conversation

@itsgrimetime

@itsgrimetime itsgrimetime commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Use typed callback and payload unions in the stage animation dispatcher so pointers retain their native width and every argument kind uses the SDK's exact signature without casts. Type the first-animation search callback and make its result pointer volatile across longjmp.

Validation: 100% matching; the final DOL is byte-identical to master. ARM64 -O2 ASan/UBSan checks cover all 12 callback signatures through the production stage and SDK walkers, plus 2,048 animation search cases.

@itsgrimetime itsgrimetime added the ai-assisted Utilizes a LLM to do the heavy lifting label Oct 13, 2026
Comment thread src/melee/gr/granime.c Outdated
@itsgrimetime
itsgrimetime enabled auto-merge (squash) October 13, 2026 17:14
@itsgrimetime
itsgrimetime merged commit 00f46b1 into doldecomp:master Oct 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Utilizes a LLM to do the heavy lifting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants