Repository navigation
rename symbols, remove pad stack in hsd_8039D9C8 - #3680
Open
HidoranBlaze wants to merge 4 commits into
Open
HidoranBlaze wants to merge 4 commits into
HidoranBlaze wants to merge 4 commits into
Conversation
HidoranBlaze
force-pushed
the
cleanup/baselib
branch
from
October 19, 2026 00:40
db3491a to
001469b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly renaming symbols here, I based this off the baselib symbol names in the Pokemon XD decomp I'm contributing to, and the symbol names in psstruct.h. I'm confident in most of my renamings except for MatToEuler and AngleAxisToQuat; I couldn't find names in the XD symbol map that seemed to fit what these two functions were doing (the candidates were DmpQuat, QuatSerp, QuatRotate and QuatSetUp), so I ended up naming them based on what the functions were doing.
Aside from that, the PAD_STACK in hsd_8039D9C8 is now removed. Also took the liberty of swapping the symbol names for psNumCmdList and psCmdListArray to fix the todo in generator.c, because the symbol names do look like they're swapped.