Repository navigation
Conversation
Report for MarioClub_us (ffc513c - b49c154)📈 Matched code: 47.11% (+0.02%, +524 bytes) ✅ 10 new matches
📈 13 improvements in unmatched items
|
Contributor
|
Hey @jt-marte - thanks so much for your contributions to the mkdd decomp project! Just letting you know that most of the classes in Shiraiwa are currently being tackled by myself in PR #49. We have a discord where we communicate who is doing what, and the general consensus is that if there is a draft PR, it means that someone is actively working on that code. Because of this, we will probably close this PR, but please don't let that discourage you from making further contributions. We'd love help especially in other modules. 😄 You can join the discord here if you haven't already. |
Collaborator
|
Unfortunately i'll have to close this, for the reasons @MB60893 provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds TMapObjWall header (layout, vtable order, statics)
Matches: constructor, getBmdFileName, initFunc_Rest, doFunc_Rest
Changes TPathMove::_8 from s16 to u16 (read with lhz in doFunc_Rest)
Note: I used an AI assistant (Claude) to help learn the workflow and analyze the assembly. I reviewed and verified all code, and every function listed matches 100% in objdiff