Skip to content

Mapobjwall: Add header and match ctor, getBmdFileName, doFunc_Rest - #89

Closed
jt-marte wants to merge 3 commits into
doldecomp:mainfrom
jt-marte:mapobjwall
Closed

jt-marte wants to merge 3 commits into
doldecomp:mainfrom
jt-marte:mapobjwall

Conversation

@jt-marte

@jt-marte jt-marte commented Oct 3, 2026

Copy link
Copy Markdown

Adds TMapObjWall header (layout, vtable order, statics)

Matches: constructor, getBmdFileName, initFunc_Rest, doFunc_Rest

Changes TPathMove::_8 from s16 to u16 (read with lhz in doFunc_Rest)

Note: I used an AI assistant (Claude) to help learn the workflow and analyze the assembly. I reviewed and verified all code, and every function listed matches 100% in objdiff

@decomp-dev

decomp-dev Bot commented Oct 4, 2026

Copy link
Copy Markdown

Report for MarioClub_us (ffc513c - b49c154)

📈 Matched code: 47.11% (+0.02%, +524 bytes)
📈 Matched data: 24.89% (+0.00%, +20 bytes)

✅ 10 new matches
Unit Item Bytes Before After
main/Shiraiwa/MapObjWall TMapObjWall::TMapObjWall(const CrsData::SObject&) +200 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::~TMapObjWall() +168 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::doFunc_Rest() +88 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::getBmdFileName() +40 0.00% 100.00%
main/Shiraiwa/MapObjWall .sbss +16 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::@332@InitExec() +8 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::@332@MoveExec() +8 0.00% 100.00%
main/Shiraiwa/MapObjWall @332@__dt__11TMapObjWallFv +8 0.00% 100.00%
main/Shiraiwa/MapObjWall .ctors +4 0.00% 100.00%
main/Shiraiwa/MapObjWall TMapObjWall::initFunc_Rest() +4 0.00% 100.00%
📈 13 improvements in unmatched items
Unit Item Bytes Before After
main/Shiraiwa/MapObjWall .data +259 0.00% 52.42%
main/Shiraiwa/MapObjWall __sinit_MapObjWall_cpp +121 0.00% 32.37%
main/Shiraiwa/MapObjWall .rodata +36 0.00% 34.92%
main/Shiraiwa/MapObjWall TMapObjWall::reset() +4 0.00% 1.45%
main/Shiraiwa/MapObjWall TMapObjWall::calc() +4 0.00% 3.23%
main/Shiraiwa/MapObjWall TMapObjWall::initFunc_Move() +4 0.00% 2.86%
main/Shiraiwa/MapObjWall TMapObjWall::createColModel(J3DModelData*) +4 0.00% 12.50%
main/Shiraiwa/MapObjWall TMapObjWall::loadAnimation() +3 0.00% 3.85%
main/Shiraiwa/MapObjWall TMapObjWall::createModel(JKRSolidHeap*, unsigned long) +3 0.00% 1.23%
main/Shiraiwa/MapObjWall TMapObjWall::InitExec() +3 0.00% 3.70%
main/Shiraiwa/MapObjWall TMapObjWall::MoveExec() +3 0.00% 3.70%
main/Shiraiwa/MapObjWall TMapObjWall::doFunc_Move() +3 0.00% 5.26%
main/Shiraiwa/MapObjWall .sdata +1 0.00% 22.22%

@MB60893

MB60893 commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Hey @jt-marte - thanks so much for your contributions to the mkdd decomp project!

Just letting you know that most of the classes in Shiraiwa are currently being tackled by myself in PR #49. We have a discord where we communicate who is doing what, and the general consensus is that if there is a draft PR, it means that someone is actively working on that code.

Because of this, we will probably close this PR, but please don't let that discourage you from making further contributions. We'd love help especially in other modules. 😄

You can join the discord here if you haven't already.

@SwareJonge

Copy link
Copy Markdown
Collaborator

Unfortunately i'll have to close this, for the reasons @MB60893 provided.

@SwareJonge SwareJonge closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants