Skip to content

Goal2D: Add class implementation. - #90

Open
cristian64 wants to merge 2 commits into
doldecomp:mainfrom
cristian64:goal2d
Open

cristian64 wants to merge 2 commits into
doldecomp:mainfrom
cristian64:goal2d

Conversation

@cristian64

Copy link
Copy Markdown
Contributor

No description provided.

@cristian64
cristian64 force-pushed the goal2d branch 5 times, most recently from e0f9bfc to 95e4666 Compare October 11, 2026 11:25
@decomp-dev

decomp-dev Bot commented Oct 11, 2026

Copy link
Copy Markdown

Report for MarioClub_us (1d2918c - a068e33)

📈 Matched code: 47.44% (+0.35%, +11228 bytes)
📈 Linked code: 42.29% (+0.37%, +11764 bytes)
📈 Matched data: 24.90% (+0.02%, +152 bytes)
📈 Linked data: 32.54% (+0.09%, +864 bytes)

✅ 25 new matches
Unit Item Bytes Before After
main/Kameda/PauseManager PauseManager::exec() +2429 0.16% 100.00%
main/Kameda/Goal2D Goal2D::Goal2D(JKRHeap*) +2376 0.17% 100.00%
main/Kameda/Goal2D Goal2D::calc() +1968 0.20% 100.00%
main/Kameda/Goal2D Goal2D::sequenceVS() +608 0.65% 100.00%
main/Kameda/PauseManager PauseManager::PauseManager(JKRHeap*) +552 0.72% 100.00%
main/Kameda/PauseManager PauseManager::draw() +548 0.72% 100.00%
main/Kameda/Goal2D Goal2D::sequenceMG() +425 0.93% 100.00%
main/Kameda/Goal2D Goal2D::setVSMGRank() +409 0.97% 100.00%
main/Kameda/Goal2D Goal2D::drawGoal() +376 1.05% 100.00%
main/Kameda/Goal2D Goal2D::drawRetire() +368 1.08% 100.00%
main/Kameda/PauseManager PauseManager::getPauseChoice() +328 1.20% 100.00%
main/Kameda/PauseManager PauseManager::reset() +209 1.89% 100.00%
main/Kameda/Goal2D Goal2D::init() +196 2.00% 100.00%
main/Kameda/Goal2D Goal2DHioNode::~Goal2DHioNode() +112 0.00% 100.00%
main/Kameda/Goal2D .sdata2 +96 0.00% 100.00%
main/Kameda/Goal2D Goal2DParam::~Goal2DParam() +72 0.00% 100.00%
main/Kameda/PauseManager PauseManager::wipeOut(int) +60 6.25% 100.00%
main/Kameda/Goal2D Goal2D::sequenceGP() +41 9.09% 100.00%
main/Kameda/Goal2D Goal2D::sequenceTA() +33 11.11% 100.00%
main/Kameda/PauseManager PauseManager::setTA() +33 11.11% 100.00%
main/Kameda/PauseManager .sdata2 +32 0.00% 100.00%
main/Kameda/Goal2D .data +24 0.00% 100.00%
main/Kameda/PauseManager Result2D::getDrawFlag() +8 0.00% 100.00%
main/Kameda/PauseManager Result2D::setDrawFlag(bool) +8 0.00% 100.00%
main/Kameda/Result2D Result2D::getResultSelector() +4 50.00% 100.00%
📈 2 improvements in unmatched items
Unit Item Bytes Before After
main/Kameda/Goal2D .rodata +398 7.14% 99.30%
main/Kameda/PauseManager .rodata +104 21.05% 97.36%
📉 1 regression in an unmatched item
Unit Item Bytes Before After
main/Kameda/Goal2D .sbss -1 28.57% 20.00%

@cristian64
cristian64 marked this pull request as ready for review October 11, 2026 21:33
@cristian64

Copy link
Copy Markdown
Contributor Author

First commit will be rebased away once #79 lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant