Repository navigation
mkw: Match KartState wipe, reset, and collision functions - #10
Open
EricOhebshalom wants to merge 4 commits into
Open
EricOhebshalom wants to merge 4 commits into
EricOhebshalom wants to merge 4 commits into
Conversation
EricOhebshalom
commented
Oct 4, 2026
EricOhebshalom
commented
Contributor
- Decompile KartState::init (100.0% match)
- Decompile KartState::reset (99.4% match)
- Decompile KartState::resetOob (100.0% match)
- Decompile KartState::updateWipe (100.0% match)
- Decompile KartState::startWipe (100.0% match)
- Decompile KartState::resetCollisionFlags (100.0% match)
- Update symbol names in config/RMCP01/module/symbols.txt
- Decompile KartState::init (100.0% match) - Decompile KartState::reset (99.4% match) - Decompile KartState::resetOob (100.0% match) - Decompile KartState::updateWipe (100.0% match) - Decompile KartState::startWipe (100.0% match) - Decompile KartState::resetCollisionFlags (100.0% match) - Update symbol names in config/RMCP01/module/symbols.txt
Report for RMCP01 (386051f - 409adf2)📈 Matched code: 5.79% (+0.02%, +1144 bytes) ✅ 8 new matches
📈 2 improvements in unmatched items
|
henrymkw
reviewed
Oct 4, 2026
There was a problem hiding this comment.
Change _84 to a u16 (or maybe a s16, whichever one makes more sense). That will avoid the casting in reset().
henrymkw
reviewed
Oct 4, 2026
| m_70 = 0; | ||
| mBoostRampType = -1; | ||
| mJumpPadType = -1; | ||
| *(u16*)_84 = 0; |
Collaborator
There was a problem hiding this comment.
To generalize, it's safe to assume that any code containing this is wrong: *(T *)
- Use u16 for _84 to eliminate cast in reset() - Add missing KartFlags enum values (accelerate, brake, drift input, etc.) - Use KART_FLAG_MASK in resetCollisionFlags() instead of hardcoded hex values
- Decompile KartState::updateStartBoostCharge - Decompile KartState::computeStartBoost - Decompile KartState::applyStartBoost - Expose KartMove::mStartBoostCharge and setStartBoostCharge - Update symbol names in config/RMCP01/module/symbols.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.