Repository navigation
[WIP] KartState: updateCollisions (86.99%) + remaining methods - #14
Closed
rasanaruto-lgtm wants to merge 1 commit into
Closed
rasanaruto-lgtm wants to merge 1 commit into
rasanaruto-lgtm wants to merge 1 commit into
Conversation
Collaborator
|
inadequate prompting |
Author
|
Re-approaching with the current, verified tree: #16 ( Re: the "inadequate prompting" close here — that was fair. This PR was an unverified 86.99% WIP and its own body said it could not be built here. #16 is built ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft/WIP: brings our
KartStatework over from the sibling repo (rasanaruto-lgtm/mkw).Adds the not-yet-decompiled
KartStatemethods, in particular:updateCollisions- currently 86.99% on objdiff. The residual is purely MWCC register coloring (a{proxy, pe, var_r28}3-cycle); all call/data bytes match.calcStartBoost,applyStartBoost,wrapCollisionFlags-style flag helpers, etc.Also adds
KartState::kartStateReload()toKartObjectProxy.hpp(reproduces an extramKartStatereload MWCC emits at a couple of RMW sites), and makesKartCollide's collision datapublicforupdateCollisionsaccess.Unverified: I cannot build this tree here (no ROM), and
KartState.hppfield names were kept as ours (mTop/_34/_70) - please sanity-check against currentmainbefore merging. Marked draft for that reason.Companion: #13 (
dol diffsymbol-remap tooling).