Repository navigation
mkw: Name ItemObj::fixScale and ItemData::table symbols - #6
Merged
Merged
Conversation
Collaborator
|
Did you mean to commit matching |
Contributor
Author
|
This pull request was just for documenting symbol changes. Let me know if there's another way I should be doing this as I'm new to decompilation as a whole |
Collaborator
No that's fine I was just checking since it was mentioned in the PR. Though people prefer to update symbol names when they are decompiled/referenced in decompiled code since the symbol name may be decided to be different later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR names two symbols in
config/RMCP01/module/symbols.txt:.text:0x8079ED4C(fn_1_28E998) ->fixScale__Q24Item7ItemObjFv.bss:0x809C2F48(lbl_1_bss_5868) ->table__Q24Item8ItemDataThe function
ItemObj::fixScale()was matched 100% on decomp.me:https://decomp.me/scratch/e0TSy
By the way to whoever's managing this project, I'm very interested in contributing to it. At the moment I'm just messing around with AI but is there a group chat where I can talk to other people who are contributing to it? My discord username is EricOheb