Repository navigation
mkw: Decompile KartSettings constructor - #7
Open
EricOhebshalom wants to merge 3 commits into
Open
EricOhebshalom wants to merge 3 commits into
EricOhebshalom wants to merge 3 commits into
Conversation
Report for RMCP01 (386051f - 2d37580)📈 Matched code: 5.77% (+0.00%, +204 bytes) ✅ 1 new match
|
em-eight
reviewed
Oct 2, 2026
em-eight
reviewed
Oct 2, 2026
| self->gpStats = (Kart::GpStats*)operator new(0x1c); | ||
| if (System::RaceConfig::spInstance->mRaceScenario.mPlayers[(u8)playerIdx].mPlayerType == | ||
| System::RaceConfig::Player::TYPE_REAL_LOCAL) { | ||
| this->raceStats = (RaceStats*)operator new(0x14); |
Collaborator
There was a problem hiding this comment.
Instead of this, do a normal ctor call and add a preliminary definition for RaceStats
class RaceStats {
u8 _unk[0x14]; // prefer to use the definitions from the ghidra project here
};that way we don't have to come back and fix such calls when RaceStats gets implemented
| this->raceStats = (RaceStats*)operator new(0x14); | ||
| if (System::RaceConfig::spInstance->mRaceScenario.mSettings.mGameMode == | ||
| System::RaceConfig::Settings::GAMEMODE_GRAND_PRIX) { | ||
| this->gpStats = (GpStats*)operator new(0x1c); |
Collaborator
There was a problem hiding this comment.
Same as the comment for RaceStats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompiles
Kart::KartSettingsconstructor at0x80592FC0(__ct__Q24Kart12KartSettingsFv), fully completingsrc/kart/KartSettings.cpp.Matched 100% on decomp.me:
https://decomp.me/scratch/xVuXe (credit: skijer)