Repository navigation
RPGraphics stuff - #172
Open
Tanline666 wants to merge 4 commits into
Open
RPGraphics stuff#172Tanline666 wants to merge 4 commits into
Tanline666 wants to merge 4 commits into
Conversation
Contributor
Author
|
To be more specific, I just mean adding getters and setters to some EGG files, as well as adjusting RPSysKokeshiIcon a bit so that it compiles properly for rev 0 |
Report for RSPE01_01 (f5a1bb5 - 6f123a1)📈 Matched code: 35.05% (+0.02%, +672 bytes) ✅ 9 new matches
📈 11 improvements in unmatched items
Report for RSPE01_00 (f5a1bb5 - 6f123a1)📈 Matched code: 8.05% (+0.10%, +3468 bytes) ✅ 29 new matches
🥀 1 broken match
📈 11 improvements in unmatched items
📉 2 regressions in unmatched items
|
Collaborator
|
could the documentation for non-RP code be removed? id like to save that for later when we better understand the lower-level stuff |
kiwi515
requested changes
Oct 15, 2026
Collaborator
|
i think we should avoid adding inlined getters unless:
the reason being that we dont know the actual API for sure yet. ive even seen instances where the programmers forget to make the return type a reference, which results in a copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the work on RPGraphics and a few other related libraries. Some of the changes here are just documentation