Repository navigation
Conversation
Report for RSPE01_01 (27fa94a - 358f1d5)📈 Matched code: 35.04% (+0.01%, +520 bytes) ✅ 2 new matches
📈 2 improvements in unmatched items
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two matching decompilation improvements for
RSPE01_01.RPGrpModelScene::DrawPrepare(...).RPGrpModelScenemembers required by the matched implementation.RPUtlRandom::getF32()soBowling::RPBowManagerContext::UpdateNpcs()reaches a full project-report match without changing the helper's behavior.The existing
UpdateNpcs()implementation is prior work by Alex9303 from #149. My contribution there is limited to resolving the remaining code-generation mismatch through the shared random helper.Verification
Built and verified with
RSPE01_01.build/RSPE01_01/main.dol: OK.RPGrpModelScene::DrawPrepare(...): project report100%;80/80.textbytes identical.Bowling::RPBowManagerContext::UpdateNpcs(): project report100%;440/440.textbytes and110/110instructions identical.getF32()change was checked against the full project progress report and produced no regressions in previously matched functions.A stricter relocation-aware objdiff comparison may display approximately
99.91%forUpdateNpcs()because of two data-relocation label differences. The generated.textis byte-identical, and the project's normal progress-report configuration reports the function at100%.AI disclosure
I used OpenAI Codex through Merlin Software's provided environment to assist with code inspection, hypothesis generation, and controlled matching experiments.
I reviewed the source changes and independently verified the results using the project's build, progress-report, and binary-comparison tooling. AI-assisted work was limited to
Packgame code; no SDK code was modified.