Support NotNullIfNotNullAttribute#19977
Open
kerams wants to merge 12 commits into
Open
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
github-actions
Bot
added
the
⚠️ Affects-Compiler-Output
Contributor
|
🔍 Tooling Safety Check — Affects-Compiler-Output
|
T-Gro
reviewed
Jun 22, 2026
T-Gro
reviewed
Jun 22, 2026
T-Gro
reviewed
Jun 22, 2026
|
|
||
| // The result is non-null when the SECOND parameter is non-null. | ||
| [return: NotNullIfNotNull("second")] | ||
| public static string? DependsOnSecond(string? first, string? second) => second; |
Member
There was a problem hiding this comment.
Could you pls also do a test for type inference of an F# function argument ? And assert what is being inferred.
let f x =
C.DependsOnSecond(x,x)
T-Gro
reviewed
Jun 22, 2026
T-Gro
reviewed
Jun 23, 2026
T-Gro
reviewed
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only supported on C# and F# methods. Functions use an entirely different pathway. Also only one instance of the attribute is supported because at that point we can't evaluate nullness of relevant arguments to link the right one (but maybe we could introduce a new type of nullness linkage). It's also exceedingly rare...
Checklist