Skip to content

feat(Reconnector): compatible net11 - #8482

Merged
ArgoZhang merged 2 commits into
mainfrom
feat-reconnector
Sep 24, 2026
Merged

ArgoZhang merged 2 commits into
mainfrom
feat-reconnector

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #8481

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Make Reconnector compatible with .NET 11 rendering while providing more reliable, configurable automatic recovery after connection loss.

New Features:

  • Support the ReconnectorOutlet with the current interactive server rendering model and expose its reconnect configuration in the sample.
  • Add configurable connection recovery polling with automatic page reload when the service becomes available.

Bug Fixes:

  • Improve reconnect lifecycle handling by starting and stopping recovery checks with connection state changes and disposing associated resources cleanly.

Enhancements:

  • Update Reconnector documentation and examples to describe automatic recovery behavior and polling interval constraints.

@sourcery-ai

sourcery-ai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Updates the Reconnector implementation for .NET 11 compatibility by adopting component lifecycle-aware JavaScript initialization and disposal, improving connection recovery polling and cleanup, and revising the sample to use the current ReconnectorOutlet render-mode syntax and documented interval behavior.

Sequence diagram for lifecycle-aware Reconnector recovery

sequenceDiagram
    participant Component as ReconnectorContent
    participant JS as Reconnector JavaScript
    participant Modal as Reconnect modal
    participant Server as Server
    participant Browser as Browser

    Component->>JS: init(id, interval)
    JS->>JS: dispose(id)
    JS->>Modal: observe class changes and state events
    JS->>JS: updateReloading()
    alt reconnect modal is visible
        JS->>JS: startReloading()
        JS->>Server: fetch('', { cache: 'no-store' })
        Server-->>JS: response.ok
        JS->>Browser: location.reload()
    else reconnect modal is hidden
        JS->>JS: stopReloading()
    end
    Component->>JS: dispose(id)
    JS->>Modal: disconnect observer and remove state handler
    JS->>JS: stopReloading()
Loading

File-Level Changes

Change Details Files
Refactor automatic reconnection into lifecycle-aware JavaScript state management.
  • Replace interval-only reconnect logic with initialization and disposal keyed by component ID.
  • Track modal visibility via mutation and custom state-change events, starting or stopping health checks accordingly.
  • Prevent overlapping reload requests, require successful no-cache responses, and clean up timers, observers, and event handlers.
src/BootstrapBlazor/Components/Reconnector/ReconnectorContent.razor.js
src/BootstrapBlazor/Components/Reconnector/ReconnectorContent.razor.cs
Update JavaScript module loading and interop initialization for reliable component lifecycle handling.
  • Enable automatic disposal for the module loader attribute.
  • Pass the component ID into the JavaScript initializer and preserve the minimum reconnect interval enforcement.
src/BootstrapBlazor/Components/Reconnector/ReconnectorContent.razor
src/BootstrapBlazor/Components/Reconnector/ReconnectorContent.razor.cs
Revise reconnect outlet usage documentation for .NET 11-compatible Razor syntax and expose outlet parameters.
  • Use the ReconnectorOutlet component with explicit reconnect interval and interactive server render mode.
  • Document automatic recovery behavior and the minimum reconnect interval.
  • Add parameter metadata for ReconnectorOutlet.
src/BootstrapBlazor.Server/Components/Samples/Reconnectors.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#8481 Make the Reconnector component compatible with .NET 11/modern Blazor rendering and component lifecycle behavior. ✅
#8481 Ensure automatic reconnection remains reliable by properly initializing, monitoring, and disposing the reconnection logic. ✅
#8481 Update the Reconnector sample documentation to demonstrate the compatible usage and expose the ReconnectorOutlet parameters. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Sep 24, 2026
@bb-auto bb-auto Bot added this to the v10.10.0 milestone Sep 24, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang enabled auto-merge (squash) September 24, 2026 02:15

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@codecov

codecov Bot commented Sep 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c9d1714) to head (c6c5076).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          777       777           
  Lines        35159     35159           
=========================================
  Hits         35159     35159           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ArgoZhang
ArgoZhang merged commit 8261656 into main Sep 24, 2026
7 checks passed
@ArgoZhang
ArgoZhang deleted the feat-reconnector branch September 24, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Reconnector): compatible net11

1 participant