Repository navigation
ENG-8834 feat(network-ops): standardize auth params; fix netexec kerberos routing (ENG-8831) - #180
Open
thomasqbrady wants to merge 1 commit into
Open
thomasqbrady wants to merge 1 commit into
thomasqbrady wants to merge 1 commit into
Conversation
Unify the authentication surface across the network-ops tool family so an autonomous agent carries one vocabulary as it chains tools in a run. - nt_hash everywhere for the NTLM hash (retire hash / hashes) - kerberos: bool across the family, with explicit aes_key / ccache params; netexec no longer guesses AES key vs ccache path by string length, which silently mis-routed valid inputs (ENG-8831) - bloodyad: use_kerberos -> kerberos; the DC connection is dc_ip, its DNS override is dc_ip_override - certipy: target -> dc_ip, and accept the family's full LMHASH:NTHASH form - document the convention in AGENTS.md; bump capability 2.2.1 -> 2.3.0 (breaking tool-arg surface change) Adds netexec Kerberos-routing regression tests, per-wrapper forwarding tests, a certipy hash-format test, and a family-wide auth-param naming guard. ENG-8831, ENG-8834
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies the authentication parameter surface across the network-ops tool family so an agent uses one vocabulary as it chains tools, and removes a silent Kerberos mis-routing in netexec.
Closes ENG-8831 and ENG-8834.
What changed
nt_hasheverywhere for the NTLM hash — retireshash(netexec) andhashes(impacket, bloodyad, krbrelayx, coercion). netexec keepsstr | list[str]since nxc accepts multiple hashes/files.kerberos: boolacross the family. netexec's singlekerberos: stris split intokerberos: bool+ explicitaes_key/ccache, dropping thelen(kerberos) == 32/64heuristic that silently mis-routed a 32/64-char ccache path to--aesKeyand a non-standard AES key to the ccache branch (ENG-8831). bloodyad'suse_kerberosfolds intokerberos.target(which is the DC) becomesdc_ip; bloodyad's DC connection becomesdc_ip, with its DNS override renameddc_ip_override.target/targetsnow consistently means the attacked host,dc_ipthe domain controller.LMHASH:NTHASHform (previously NT-only).capabilities/AGENTS.md; capability bumped 2.2.1 → 2.3.0 (breaking tool-arg surface change).Tests
--use-kcache(not--aesKey),aes_key→--aesKey, mutual-exclusion guard,nt_hash→-H.Notes
Breaking change: callers using the old arg names (
hash/hashes,kerberos=<str>,use_kerberos, bloodyadhost, certipytarget) must update. No skill/agent markdown used literal kwargs, so the prose layer is unaffected. The dreadnode-tiger submodule pointer should be bumped to this once merged.