Repository navigation
ENG-8835 fix(network-ops): redact credentials from tool logs and traces - #183
Open
thomasqbrady wants to merge 1 commit into
Open
thomasqbrady wants to merge 1 commit into
thomasqbrady wants to merge 1 commit into
Conversation
…835) Network-ops tools pass passwords, NT hashes, Kerberos AES keys and PFX passwords as command-line arguments, exposing them in execute() logs and in tool-call trace telemetry. - Thread each tool call's credential values into execute(secrets=...) so they are masked in the logged command line and in the returned/raised output. - Recover and mask credentials carried in opaque `args` lists (certipy, netexec) and in the per-tool logger.info argument lines. - Mask the password in smb_list_files, which runs smbclient directly. - Add --add-computer / --computer-pass / -pfx-password to the relay listener's logged-command redaction. Rebased onto the ENG-8834 auth-vocabulary changes (nt_hash / aes_key / ccache). Requires the SDK execute() `secrets` parameter (dreadnode-tiger, same ticket).
thomasqbrady
force-pushed
the
eng-8835-network-ops-credential-redaction
branch
from
October 19, 2026 19:13
0f05cba to
7b23976
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network-ops tools passed passwords, NT/LM hashes, Kerberos keys and PFX passwords as command-line arguments, exposing them in
execute()logs and in tool-call trace telemetry. This threads each tool call's credential values into the SDK'sexecute(secrets=...)so they are masked at the sinks.Changes
execute()call sites across bloodyAD, impacket, netexec, certipy, krbrelayx, coercion and smbclient now passsecrets=[...]— auth credentials plus operation secrets (new/computer/PFX passwords, Kerberos AES keys,--add-computerpasswords).argslists and mask them in theirlogger.infoargument lines.execute()) masks the user-supplied--add-computerpassword in its output.smb_list_files, which runssmbclientdirectly, masks the password in its result.impacket.pybeing reformatted by the repo's pinned ruff-format hook on first touch.Dependency
Requires the SDK
execute(secrets=...)parameter — see the companiondreadnode-tigerPR for the same ticket.Validation
pytest capabilities/network-ops/tests/— 58 passing.Known residual tracked in ENG-8921: a cleartext password passed via the overloaded
-p/-Hflag inside an opaqueargslist is masked in logs but still reaches the trace span.